Update after selection in Color Picker #766
Conversation
… the Color Picker window. Remove unnecessary initializePresenters in StSettingSectionPresenter.
|
Fixes #767 |
There was a problem hiding this comment.
please review those small issues (specially the first one).
notice that it is possible that you do not want a builder, in that case, please ensure in the other side (the one that will use the result of asSettingPresenter), there is an owner set to the resulting presenter.
| settingsTarget := aSettingDeclaration realTarget perform: aSettingDeclaration targetSelector. | ||
| settingsTarget perform: aSettingDeclaration getSelector ]. | ||
|
|
||
| settingPresenter := (SpPresenter new instantiate: StSettingSHStyleButtonColorPresenterItem on: aSettingDeclaration). |
There was a problem hiding this comment.
this is equivallent to just StSettingSHStyleButtonColorPresenterItem on: aSettingDeclaration, no need of the bureaucracy... and in any case is not recommended to do it like that. Which is the application that presenter belongs to?
(this still can work if you will after add that presenter to another that knows its app, or set the app, but as is, it doesn't)
The recommended way of doing this is by passing a builder (see SpPresenterBuilder)
There was a problem hiding this comment.
Thanks. I'll address the suggested changes in a new issue
|
|
||
| colorPickerPresenter := aPresenter instantiate: SpColorPickerWindow on: self. | ||
| colorPickerPresenter | ||
| whenChangedDo: [ : c | |
There was a problem hiding this comment.
I prefer real names "aColor" or something like that.
There was a problem hiding this comment.
Same as above, I will address the changes in a new issue.
|
and now you need to give me a new PR fixing that, as @Ducasse merged :P |
Update each settings browser button color when a color is accepter in the Color Picker window.
Remove unnecessary initializePresenters in StSettingSectionPresenter.